Merge pull request #172 from parente/403-not-402

Switch 402 to 403 for kernel limit status
jupyter-server · Jun 16, 2016 · 2a329b4 · 2a329b4
2 parents 28ccaf9 + d1654a2
commit 2a329b4
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 6 deletions.
diff --git a/kernel_gateway/services/api/swagger.json b/kernel_gateway/services/api/swagger.json
@@ -178,7 +178,7 @@
                             }
                         }
                     },
-                    "402": {
+                    "403": {
                         "description": "The maximum number of kernels have been created.",
                         "schema": {
                             "$ref": "#/definitions/Error"

diff --git a/kernel_gateway/services/api/swagger.yaml b/kernel_gateway/services/api/swagger.yaml
@@ -127,7 +127,7 @@ paths:
               description: Model for started kernel
               type: string
               format: url
-        402:
+        403:
           description: The maximum number of kernels have been created.
           schema:
             $ref: '#/definitions/Error'

diff --git a/kernel_gateway/services/kernels/handlers.py b/kernel_gateway/services/kernels/handlers.py
@@ -32,15 +32,14 @@ def post(self):
         Raises
         ------
         tornado.web.HTTPError
-            402 Payment Required (for lack of a better HTTP error code and
-            mimicking what Google does) if the limit is reached
+            403 Forbidden if the limit is reached
         """
         max_kernels = self.settings['kg_max_kernels']
         if max_kernels is not None:
             km = self.settings['kernel_manager']
             kernels = km.list_kernels()
             if len(kernels) >= max_kernels:
-                raise tornado.web.HTTPError(402, 'Resource Limit')
+                raise tornado.web.HTTPError(403, 'Resource Limit')
 
         # Try to get env vars from the request body
         model = self.get_json_body()

diff --git a/kernel_gateway/tests/test_jupyter_websocket.py b/kernel_gateway/tests/test_jupyter_websocket.py
@@ -292,7 +292,7 @@ def test_max_kernels(self):
             body='{}',
             raise_error=False
         )
-        self.assertEqual(response2.code, 402)
+        self.assertEqual(response2.code, 403)
 
         # Shut down the kernel
         kernel = json_decode(response.body)