[Issue: 103] Proof point: See if notebook-http mode can be made a "plugin" #171
Conversation
nitind
changed the title
|
Replaces PR #161 |
|
It's hard to see what comments from the last PR are addressed in this new one, which aren't, and what else might have changed over all. Can you summarize? |
| module_name = 'kernel_gateway.jupyter_websocket' | ||
| elif module_name == 'notebook-http': | ||
| module_name = 'kernel_gateway.notebook_http' | ||
| api_module = importlib.import_module(module_name) |
There was a problem hiding this comment.
Instead of hardcoding these, how about:
try:
api_module = importlib.import_module(module_name)
except ImportError:
api_module = importlib.import_module('kernel_gateway.'+module_name)
It's a cost at startup only, so the initial miss for the two built-in cases isn't a huge deal.
There was a problem hiding this comment.
Generally sounds better, but wouldn't it cause reported ImportErrors for properly missing modules to always be one that favors the 'kernel_gateway.'+ name?
There was a problem hiding this comment.
Yes. Good point. We'd still get the import error, but the exception log would be useless for tracking it down.
Let's keep it the way you've got it with the if-else for now for that reason.
…e modules. For #103 (c) Copyright IBM Corp. 2016
|
Rebased in #173 , with just the specifics of the personality constructors possibly in need of more guidance. |
For issue #103
(c) Copyright IBM Corp. 2016