Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can extra_arguments be made configurable in ExecutePreprocessor? #1254

Closed
tdpetrou opened this issue May 14, 2020 · 2 comments
Closed

Can extra_arguments be made configurable in ExecutePreprocessor? #1254

tdpetrou opened this issue May 14, 2020 · 2 comments

Comments

@tdpetrou
Copy link

In the ExecutePreprocesor class, the extra_arguments traitlet is not configurable (i.e. we cannot do c.ExecutePreprocessor.extra_arguments = [commands here]) because it is not defined with .tag(config=True).

I'm guessing there is a reason for this.

I see that I can set it with the constructor ExecutePreprocessor(extra_arguments=[commands here]), but it seems like one of the only traitlets that's not configurable.

@MSeal
Copy link
Contributor

MSeal commented May 20, 2020

This is probably an oversight afaik. However this code now lives in https://github.com/jupyter/nbclient/blob/master/nbclient/client.py#L136 if you wanted to make a PR there.

@tdpetrou
Copy link
Author

Thanks, I'll create an issue/PR over there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants