Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Mistune 3.0 #1809

Closed
blink1073 opened this issue Jul 14, 2022 · 8 comments
Closed

Support Mistune 3.0 #1809

blink1073 opened this issue Jul 14, 2022 · 8 comments

Comments

@blink1073
Copy link
Member

Mistune 3.0 is changing some of the Renderer APIs in its alpha releases. For now we are pinning to <3 (#1808), but we should add compatibility once the API settles down.

@blink1073
Copy link
Member Author

Initial attempt was in #1807

@TiagodePAlves
Copy link
Contributor

Didn't know you were handling this already, so I ended up making another PR #1820.

@blink1073
Copy link
Member Author

No worries, thanks for working on it! I'll close my PR.

@anick16
Copy link

anick16 commented Aug 10, 2022

Hi guys, do we have any expected date of release for this change?
I am using the latest nbconvert 6.5.0 which has hard dependency on mistune 0.8.4. This mistune version has been found with security issue CVE-2022-34749 and fixed in mistune 2.0.3.

@blink1073
Copy link
Member Author

Hi @anick16, we're planning a new release with mistune 2.0 support next week. In the mean time you can use the prerelease as pip install --upgrade --pre nbconvert.

@rikardn
Copy link

rikardn commented Jun 15, 2023

Version 3 of mistune is now out. Any idea if the pin can be lifted in nbconvert? I could help testing if needed.

@rikardn
Copy link

rikardn commented Sep 11, 2023

I noticed that the pin on mistune was lifted so I tested and it works fine in my use case. I think this issue could be closed.

@blink1073
Copy link
Member Author

Sounds good, thanks for confirming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants