Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nbconvert does not honor "isolate" property of display_data #290

Closed
jankatins opened this issue Apr 13, 2016 · 4 comments · Fixed by #964
Closed

nbconvert does not honor "isolate" property of display_data #290

jankatins opened this issue Apr 13, 2016 · 4 comments · Fixed by #964
Milestone

Comments

@jankatins
Copy link
Contributor

The R kernel sends svg plots with the "isolate" metadata set. This is used in the notebook to embed the svg in an iframe. nbconvert does not do this, the svg is inserted directly in the exported html, which causes it to be garbled :-/:

Example: https://stackoverflow.com/questions/35827734/trouble-when-exporting-notebook-to-html-on-jupyter-with-r-kernel/36605462#36605462

You can find a notebook and an exported html file here: https://gist.github.com/janschulz/247597c6a09382987475647e4964702d

-> The second plot displays nicely in the notebook, but has garbled x axis labels in the exported html.

@flying-sheep: did I mention that I hate our current plotting type defaults? I think I did :-)

@flying-sheep
Copy link
Contributor

text, PNG, and SVG seems perfectly sane. the only problem is that you can’t simply plot thousands of dots without lagging, but that’s OK since there’s no way you could understand thousands of dots in a plot, so you have to do some statistic anyway.

i also like SVG being there because it exposes bugs in IRkernel and jupyter (like this one).

i like seeing bugs, instead of knowing they’re there, lurking in the dark

@takluyver
Copy link
Member

I already filed #129 about this, so closing as a duplicate. We worked out a way forwards in that issue if someone wants to work on it.

I'm staying neutral on the default plot formats for now :P

@takluyver takluyver added this to the no action milestone Apr 13, 2016
@jankatins
Copy link
Contributor Author

Sorry my bad, only searched for "isolate", but it's actually "isolated" and github doesn't find partial words :-(

@takluyver
Copy link
Member

No problem, these things happen.

@minrk minrk mentioned this issue Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants