Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mathjax redraw in slides #79

Closed
akhmerov opened this issue Aug 1, 2015 · 6 comments
Closed

Mathjax redraw in slides #79

akhmerov opened this issue Aug 1, 2015 · 6 comments
Labels
format:Slides pertains to exporting to the Slides format
Milestone

Comments

@akhmerov
Copy link
Member

akhmerov commented Aug 1, 2015

I have observed that slides generated by nbconvert from current master trigger mathjax redraws on every navigation event:

See
http://nbviewer.ipython.org/format/slides/url/antonakhmerov.org/misc/slides_mathjax_render.ipynb (nbviewer seems to have the same issue)

In case nbviewer code is modified, here's the generated html:
http://antonakhmerov.org/misc/slides_mathjax_render.slides.html

The bug manifests in blinking of $\LaTeX$ when the next fragment is shown.

Resolving #67 could solve also this issue.

@damianavila
Copy link
Member

This is because in nbviewer the mathjax redraw is associated to the slidechanged and fragmentchange events. Preoviously, only the slidechanged event triggered the redraw...

I think we probably have to go back and only triggers the redraw with the slidechange as the reveal.js math plugin does...

@damianavila damianavila added the format:Slides pertains to exporting to the Slides format label Aug 2, 2015
@takluyver takluyver added this to the 4.1 milestone Aug 2, 2015
@takluyver
Copy link
Member

Milestoned for 4.1 because it sounds simple and hopefully the fix can get in quickly, but we can bump it if necessary.

@takluyver
Copy link
Member

@damianavila can you look into this? I'd like to be able to release 4.1 today or tomorrow.

@damianavila
Copy link
Member

I will look into this at the evening if that works for you...

@takluyver
Copy link
Member

OK, thanks

@damianavila
Copy link
Member

I just submitted a fix @takluyver 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
format:Slides pertains to exporting to the Slides format
Projects
None yet
Development

No branches or pull requests

3 participants