Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nbextension install output should go to stdout #1797

Open
minrk opened this issue Sep 29, 2016 · 2 comments
Open

nbextension install output should go to stdout #1797

minrk opened this issue Sep 29, 2016 · 2 comments
Milestone

Comments

@minrk
Copy link
Member

minrk commented Sep 29, 2016

The refactor in 4.2 switched to using the logging module for nbextension install, but this goes to stderr by default. We shouldn't write anything to stderr when installing or uninstalling an extension without an error.

In general, I think using the application logger is probably not the right thing to do for most of the output in nbextension/serverextension actions, and we should be using print to stdout, stderr instead.

@minrk minrk added this to the 4.3 milestone Sep 29, 2016
@takluyver
Copy link
Member

It's fine for application code (e.g. InstallNBExtensionApp) to use simple print(). But for API functions like install_nbextension(), I think it's better for them to use the logging machinery unless writing output to the terminal is explicitly what the function is for - which it's not in this case.

I'm not sure why it matters that stuff is written to stderr instead of stdout, though? I think of stderr as a side-channel to display info to the user when the main output channel is redirected; it doesn't necessarily indicate that something has gone wrong.

@minrk minrk modified the milestones: 5.0, 4.3 Dec 2, 2016
@minrk
Copy link
Member Author

minrk commented Dec 2, 2016

It's a minor annoyance to me because I think we are managing output wrong, but no need to block a release for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants