Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New kernel_info_timeout breaks Websocket handshake #3711

Open
mpacer opened this issue Jun 25, 2018 · 0 comments
Open

New kernel_info_timeout breaks Websocket handshake #3711

mpacer opened this issue Jun 25, 2018 · 0 comments

Comments

@mpacer
Copy link
Member

mpacer commented Jun 25, 2018

In #3665 I made it so that the initial startup for the kernel uses the same timeout as our restart logic. I believe this is because the websocket times out.

For some reason, I have no issues with this when working with this locally, only remotely.

There is a simple fix for this, by making the timeout change only apply to the restart (which does work on its own). However, the real problem has to do with the fact that the websocket handshake can be achieved via some other means, rather than tied to the activity of the kernel. Fixing that so that we can have better visibility on the state of the kernel (independent on the success of the handshake, since that isn't strictly needed or the current timeout mechanism would stop slow kernels from ever starting).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant