Bug when renaming file (notebook 6.4.12)

[jinzhen-lin]

Describe the bug
In notebook 6.4.12，we cannot rename file sometimes.

To Reproduce
Steps to reproduce the behavior:

1. Install notebook 6.4.12
2. Start notebook with root_dir="/home/foobar"
3. Create a directory named abc (or any name with length len(root_dir) - len("Untitled") - 1)
4. Create a notebook with default filename 'Untitled.ipynb'
5. Rename the notebook to any other filename

Then you should got the error message

File "/home/xxxxxxx/.miniconda3/lib/python3.8/site-packages/notebook/services/contents/filemanager.py",
line 579, in rename_file raise web.HTTPError(400, f'Cannot rename hidden file or directory {os_path!r}')
NameError: name 'os_path' is not defined

Expected behavior

Rename the file successfully.

According to the error message, I found a typo here (os_path is not defined, it should be old_path). .

notebook/notebook/services/contents/filemanager.py

Lines 578 to 579 in 3e5b767

	if (is_hidden(old_path, self.root_dir) or is_hidden(new_path, self.root_dir)) and not self.allow_hidden:
	raise web.HTTPError(400, f'Cannot rename file or directory {os_path!r}')

And I notice that the result of is_hidden(old_path, self.root_dir) is true, this is because the result of "abc/Untitled.ipynb"[len("/home/foobar"):] is .ipynb and it is treated as a hidden file.

It seems that this bug is introduced by this commit f69eb96 .

[braceletboy]

I faced this same error too. Can someone fix this?

[pyh-129]

I faced this same error too. Can someone fix this?

Me too!

[YoannCheung]

Same error. I have to rename it in the file folder after I close the jupyter notebook.

[player999]

The same.

[sbushmanov]

Please resolve the bug

[pyh-129]

Hi， After I rename it, it will be fine. I continue to check the information. It may have the same name as a file in the system Message ID: ***@***.***>

[yacchin1205]

I faced this same error too.

[ztsweet]

i get the same error

[charlesnyankieya]

Just rename it offline and reload the page. It should work

[sanchezis]

notebook/services/contents/filemanager.py

There is an error on this file rename function (line 500+)

The only way how to solve this situation is to downgrade...

pip3 install --upgrade notebook=="6.4.11"

[BhagatSurya]

notebook/services/contents/filemanager.py

There is an error on this file rename function (line 500+)

The only way how to solve this situation is to downgrade...

pip3 install --upgrade notebook=="6.4.11"

thanks it helps

[zyzand]

This problem also exists in version 6.5.2

[RRosio]

@zyzand The latest release of Notebook, 6.5.3 should include the fix by @yacchin1205. Would you be able to upgrade to 6.5.3 and see if you still experience this issue?

[zyzand]

It works after I upgrade to version 6.5.3. Thanks.

@zyzand The latest release of Notebook, 6.5.3 should include the fix by @yacchin1205. Would you be able to upgrade to 6.5.3 and see if you still experience this issue?

[RRosio]

Thank you @zyzand! As there has been a release with a fix for this issue, I will go ahead and close it.