Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Javascript syntax fixes #3294

Merged
merged 1 commit into from Feb 26, 2018

Conversation

Projects
None yet
2 participants
@takluyver
Copy link
Member

takluyver commented Feb 2, 2018

This fixes some issues spotted by Pycharm's linter.

I know we generally don't go for 'big cleanup' PRs, so I've tried to keep the scope of this quite limited - for now, I've only changed notebook.js with simple improvements. Linters are more useful the fewer existing issues they show up, so if we're happy with this I might do similar cleanups to other files.

One common source of warnings is unused function parameters. Unlike in Python, a Javascript function can be called with more arguments than it has: the extra arguments are ignored. This is a questionable language feature, but handy for things like some_array.map(function (elt) {...});.

@gnestor
Copy link
Contributor

gnestor left a comment

LGTM!

@gnestor gnestor added this to the 5.5 milestone Feb 20, 2018

@takluyver takluyver merged commit 2aac713 into jupyter:master Feb 26, 2018

4 checks passed

codecov/patch Coverage not affected when comparing 08a17df...1d806da
Details
codecov/project 78.76% remains the same compared to 08a17df
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@takluyver takluyver deleted the takluyver:notebook-js-syntax-fixes branch Feb 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.