Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Javascript syntax fixes #3294

Merged
merged 1 commit into from Feb 26, 2018
Merged

Conversation

@takluyver
Copy link
Member

@takluyver takluyver commented Feb 2, 2018

This fixes some issues spotted by Pycharm's linter.

I know we generally don't go for 'big cleanup' PRs, so I've tried to keep the scope of this quite limited - for now, I've only changed notebook.js with simple improvements. Linters are more useful the fewer existing issues they show up, so if we're happy with this I might do similar cleanups to other files.

One common source of warnings is unused function parameters. Unlike in Python, a Javascript function can be called with more arguments than it has: the extra arguments are ignored. This is a questionable language feature, but handy for things like some_array.map(function (elt) {...});.

Copy link
Contributor

@gnestor gnestor left a comment

LGTM!

Loading

@gnestor gnestor added this to the 5.5 milestone Feb 20, 2018
@takluyver takluyver merged commit 2aac713 into jupyter:master Feb 26, 2018
4 checks passed
Loading
@takluyver takluyver deleted the notebook-js-syntax-fixes branch Feb 26, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants