Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix going back to root directory with history in notebook list #3411

Merged
merged 1 commit into from Mar 15, 2018

Conversation

@takluyver
Copy link
Member

@takluyver takluyver commented Mar 9, 2018

Bug found during pair programming with @mpacer

@takluyver takluyver added this to the 5.5 milestone Mar 9, 2018
@mpacer mpacer mentioned this pull request Mar 9, 2018
@takluyver
Copy link
Member Author

@takluyver takluyver commented Mar 9, 2018

To elaborate a bit, the bug manifests when you click into a subdirectory from the tree view, and then use the back button to return to the first view that was loaded. The history entry for this has an empty state object, but that's still truthy in Javascript, so it was taking .path from it, which was undefined.

While fixing this, we realised that the fallback was also to the server root directory instead of the first directory loaded - they're normally the same, but don't have to be. So that is also fixed.

Loading

@takluyver
Copy link
Member Author

@takluyver takluyver commented Mar 13, 2018

I'll merge this tomorrow unless anyone wants more time to review it.

Loading

@takluyver takluyver merged commit 276474a into jupyter:master Mar 15, 2018
4 checks passed
Loading
@takluyver takluyver deleted the notebooklist-back-to-start branch Mar 15, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant