Revert "[MRG] Start reusing existing docker images if content hasn't changed" #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In discussion with @betatim, we are going to revert this for now. Then we can redo this, but this time with Tests and Docs, and merge it again :) |
yuvipanda
added a commit
to yuvipanda/repo2docker
that referenced
this pull request
Dec 10, 2018
Merges in this revert: jupyterhub#481
markmo
pushed a commit
to markmo/repo2docker
that referenced
this pull request
Jan 22, 2021
Revert "[MRG] Start reusing existing docker images if content hasn't changed"
markmo
pushed a commit
to markmo/repo2docker
that referenced
this pull request
Jan 22, 2021
Merges in this revert: jupyterhub#481
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #461
This was causing the --image-name parameter to be ignored,
due to unconditional setting of
output_image_specinfetch.