Provide help text for commandline arguments #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrbourbeau
reviewed
Dec 18, 2018
There was a problem hiding this comment.
Good catch @yuvipanda, thanks for fixing this! I've attached one nitpicky comment.
repo2docker/__main__.py
Outdated
| ) | ||
|
|
||
| argparser.add_argument( | ||
| '--subdir', | ||
| type=str, | ||
| #help=self.traits()['subdir'].help, | ||
| help=Repo2Docker.subdir.help |
There was a problem hiding this comment.
The current help message for subdir is
Subdirectory of the git repository to examine. Defaults to ‘’.
Perhaps something like "Defaults to the root of the repository" is slightly more clear. What do you think?
markmo
pushed a commit
to markmo/repo2docker
that referenced
this pull request
Jan 22, 2021
Provide help text for commandline arguments Co-authored-by: Min RK <benjaminrk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.