Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabling search and replace #82

Closed
kgoo124 opened this issue Jul 20, 2020 · 0 comments · Fixed by #83
Closed

Enabling search and replace #82

kgoo124 opened this issue Jul 20, 2020 · 0 comments · Fixed by #83
Labels
enhancement New feature or request

Comments

@kgoo124
Copy link
Member

kgoo124 commented Jul 20, 2020

Describe the new feature being added

  • Users can use Accel F to search for some text in the DataGrid
  • Users can also access the Replace and Replace All feature

How will this feature improve this extension

  • Bigger datasets are easier to search
  • Similiar things that need to be changed can be changed all at one time

Describe alternatives you've considered
N/A

Additional context

  • Using an adapted version of searchprovider.ts from the csvviewer-extension package
@kgoo124 kgoo124 added the enhancement New feature or request label Jul 20, 2020
@kgoo124 kgoo124 mentioned this issue Jul 20, 2020
Merged
@ghost ghost closed this as completed in #83 Jul 22, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Search/replace functionality + working theme manager kgoo124/jupyterlab-tabular-data-editor
1 participant
@kgoo124