Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild image only if environment.yml changes #746

Closed
emarsden opened this issue Dec 3, 2018 · 1 comment
Closed

Rebuild image only if environment.yml changes #746

emarsden opened this issue Dec 3, 2018 · 1 comment

Comments

@emarsden
Copy link

emarsden commented Dec 3, 2018

Binderhub seems to be building a new image for each commit to the git repository. Given that image rebuilds are very expensive, and that notebooks are likely to be updated far more often than environment.yml / requirements.txt, it seems that it would be more efficient to rebuild an image only when there is a change to a hash of whatever elements repo2docker used to generate the image.

@betatim
Copy link
Member

betatim commented Dec 3, 2018

This behaviour is unlikely to change. The reason for this is that (for example) what happens if you install software according to a requirements.txt can depend on any other file in the repository. We are not aware of any good way of detecting the full chain of dependencies in an automatic way.

There are attempts to speed up builds in these issues: jupyterhub/repo2docker#461 jupyterhub/repo2docker#478 and jupyterhub/repo2docker#410.

Closing this to keep the discussion focussed in the issues/PRs where there is a concrete suggestion on how to improve this. Please join in there and help test things or give feedback on the ideas.

@betatim betatim closed this as completed Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants