-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Easy to fix docs corrections #113
Comments
Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗 |
I have read the source code , now I know that the official documentation is wrong. The source code like this: allow_2fa = Bool(
False,
config=True,
help=""
)
class SignUpHandler(LocalBase):
"""Render the sign in page."""
async def get(self):
if not self.authenticator.enable_signup:
raise web.HTTPError(404)
self._register_template_path()
html = self.render_template(
'signup.html',
ask_email=self.authenticator.ask_email_on_signup,
two_factor_auth=self.authenticator.allow_2fa,
)
self.finish(html) Hence, If you set |
add_two_factor_authentication
not recognized by NativeAuthenticator
@xrdy511623 thanks for writing an issue about this and summarizing what the solution was! I'm opening it again until the documentation is fixed. Issue summaryThe documentation here use the wrong configuration name ( nativeauthenticator/docs/options.rst Line 122 in e66ef40
|
Also, the options.rst on minimum password length is wrong, which sets the attribute like this: However, it can not be recognized by nativeauthenticator for spelling mistake, the correct setting should be like this: c.Authenticator.minimum_password_length = 10 |
Bug description
in the jupyterhub_config.py, I set
c.Authenticator.add_two_factor_authentication = True
. However,while I start jupyterhub service, a warning occurs that Config option
add_two_factor_authentication
not recognized byNativeAuthenticator
. Anyone who knows where I went wrong?Expected behaviour
I except the configuration that c.Authenticator.add_two_factor_authentication = True would take effect.
Actual behaviour
As a result, a warning occurs that Config option
add_two_factor_authentication
not recognized byNativeAuthenticator
.The text was updated successfully, but these errors were encountered: