Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GitHub] We can authorize organizations, but what about teams within them? #265

Closed
scottyhq opened this issue May 21, 2019 · 2 comments · Fixed by #449
Closed

[GitHub] We can authorize organizations, but what about teams within them? #265

scottyhq opened this issue May 21, 2019 · 2 comments · Fixed by #449

Comments

@scottyhq
Copy link

Currently GitHub authentication is setup to whitelist individual users or entire organizations:
https://github.com/jupyterhub/oauthenticator/blob/master/oauthenticator/github.py

See here for the implementation:
https://zero-to-jupyterhub.readthedocs.io/en/latest/authentication.html?highlight=auth#github

It would be great to be able to whitelist Teams within a given organization:
https://developer.github.com/v3/teams/members/#get-team-membership

We are currently creating many new organizations on github for week-long tutorials to grant time-limited access to hubs. Having team-based authentication could help with a few scenarios:

  1. medium/large github organizations with application-specific hubs (https://github.com/pangeo-data)

  2. could also be a really useful feature for resource access based on team membership within a hub (for example, mapping team name to group id)?

@yuvipanda
Copy link
Collaborator

I'm pretty sure we'd love a PR!

@consideRatio consideRatio changed the title GitHub authentication for Organization Teams [GitHub] We can authorize organizations, but what about teams within them? Oct 25, 2020
@sgibson91
Copy link
Member

I'm gonna work on this as part of Pangeo's migration to 2i2c 🙂 2i2c-org/infrastructure#482 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants