Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record default command used to run repo2docker in Dockerfile #546

Open
yuvipanda opened this issue Jan 5, 2019 · 3 comments
Open

Record default command used to run repo2docker in Dockerfile #546

yuvipanda opened this issue Jan 5, 2019 · 3 comments

Comments

@yuvipanda
Copy link
Collaborator

yuvipanda commented Jan 5, 2019

When running repo2docker, we might want to record the 'default command' the user wants to run there. This is useful when running the image outside of repo2docker itself. But we have to be careful about what this means for caching.

Similar to #545 and split from #533 (comment)

@yuvipanda
Copy link
Collaborator Author

We might wanna separate this out from the runtime command, maybe - but wanna do the 'right thing' by default as well.

@betatim
Copy link
Member

betatim commented Jan 5, 2019

The idea would be to record the build time repo2docker https://github/org/repo my-command-here arg1 arg2 in the Dockerfile by having CMD my-command-here arg1 arg2 (or ENTRYPOINT? Tim can't remember when to use which). Replacing the default which we put in right now independent of what command is specified by the user as argument to repo2docker.

@manics
Copy link
Member

manics commented May 17, 2021

It's been a couple of years, do you still think we should add this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants