Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JupyterHub and Jupyter got into the open-source program for dockerhub! #559

Closed
consideRatio opened this issue Aug 28, 2022 · 27 comments
Closed

Comments

@consideRatio
Copy link
Member

consideRatio commented Aug 28, 2022

@mathbunnyru advocated for a submission into DockerHub's Open Source program. An application was submitted and has now been accepted!

I received this email:

Congratulations! The Jupyter and Jupyterhub projects have been approved for the Docker-Sponsored Open Source program. A Docker Team subscription will be allocated to your Docker Hub organization within 14 days. In addition to a Team subscription, you now have:

  • free autobuilds
  • rate-limit removal for all users pulling public images from your project namespace
  • special badging on Docker Hub (this will be visible within two weeks)

If you haven’t already, please take the time to update your project’s Hub pages to include a detailed project description, links to your project source code, as well as contributing guidelines, and a link to your organization’s website. Projects lacking this information may not receive the Docker Sponsored Open Source badging for their images on Docker Hub.

Membership in the Docker-Sponsored Open Source (DSOS) program is valid for one year. You will receive a reminder email from us when it is time to renew your membership.

We are thrilled to have you as an open-source partner. If you have any questions regarding the open source program please contact opensource@docker.com and include the name of your project in the subject line. If you have questions regarding technical support please contact support@docker.com.

Thank you!

@mathbunnyru
Copy link

Great news, Erik, thank you!

When (and if) it becomes possible, please add me to the DockerHub team as well :)
jupyter/docker-stacks#1309

@choldgraf
Copy link
Member

hooray! thanks @mathbunnyru for making an application for the team!

@consideRatio
Copy link
Member Author

The application was easy to write, but to even find the form to apply etc we had to speak with dockerhub - the button to apply was missing from the website ;D Thank you @mathbunnyru for making this happen!

Adding Ayaz to hub.docker.com's Jupyter organization

When (and if) it becomes possible, please add me to the DockerHub team as well :)

So far I can't invite members to the JupyterHub organization where I have owner permissions, but I assume we are enabled doing that soon.

image

When such permissions is granted for the jupyter and jupyterhub organization I hope we can add members. @minrk are you an owner in the jupyter organization on hub.docker.com?

Adding image repository descriptions

As described in the email, they want us to add descriptions to the image repositories linking out to the source code etc. That makes perfect sense to me and I'm happy to work on getting that done.

But I'd like to clear out a few image repositories that I don't think are used any more.

@jupyterhub/jupyterhubteam do you agree its okay to delete the image repositories aged more than 4+ years old as seen in the screenshots below?

JupyterHub organization on hub.docker.com:
image

Jupyter organization on hub.docker.com:
image

@mathbunnyru
Copy link

Everything seems to work 👍

Снимок экрана 2022-09-01 в 09 38 12
Снимок экрана 2022-09-01 в 09 38 20

@manics
Copy link
Member

manics commented Sep 20, 2022

Can you get any stats on when images were last pulled? e.g. for the images with 100K+ pulls, how many pulls were in the past year?

@consideRatio
Copy link
Member Author

Yepp, for the jupyterhub organization's images I can see that because I'm an admin there, but not in the jupyter part.

A B
image image
image image
image image

@manics
Copy link
Member

manics commented Sep 20, 2022

Can you get pulls/month? If an image is pulled once a month by some automated external security scanning company we don't care, but if it's 100/week we should probably keep them.

@manics
Copy link
Member

manics commented Sep 20, 2022

How about a cutoff of 1000 total pulls? Delete if there are fewer, document if there are more?

@minrk
Copy link
Member

minrk commented Sep 21, 2022

  • All the k8s- images are built from zero-to-jupyterhub, and no longer built because they've been removed from the chart.

  • systemuser was built from dockerspawner. SystemUserSpawner used to rely on some bootstrapping steps in the image itself, but that requirement was removed, so it can work with any image.

@minrk
Copy link
Member

minrk commented Sep 21, 2022

tljh-circleci-base-image was used in tljh CI, but not anymore. That's clearly for internal use only, and safe to remove since we aren't using it.

@consideRatio
Copy link
Member Author

  • I've now deleted the jupyterhub org's images: k8s-image-puller, k8s-rateproxy, and tljh-circleci-base-image
  • I've concluded that there is "Insights & Analytics" available, but I only found it on my mobile, and not via my computer. So, I presume its some A/B testing kind of thing going on.
    image
  • Downloaded compressed .csv files, unpacked, revealed the following information:
    • k8s-pod-culler: downloaded 100+ times during august 2022 from at least 10 different IPs, seemingly associated with version 0.7.0 of z2jh --- conclusion, its actively relevant still, but only for a very outdated version of z2jh - not to be deleted
    • k8s-pre-puller: only one tag was used, and it was downloaded 1 time during august 2022. It is referencing a version between v0.5 and v0.6 --- conclusion, we could retain it, but I suggest we delete it and hope it was an automated vulnerability scanner downloading the image rather than a real deployment.

What do you think about deleting also k8s-pre-puller?

@minrk
Copy link
Member

minrk commented Sep 21, 2022

Is there a benefit to deleting it? I don't really understand proactively deleting published artifacts from the internet.

@minrk
Copy link
Member

minrk commented Sep 21, 2022

To be clear - I think we should leave it alone because it was part of a published release, and already has a readme, Dockerfile, etc. If it were only an interim image, deleting makes sense to me.

@consideRatio
Copy link
Member Author

Since its part of a published release, let's retain it. I can document whats needed in the jupyterhub org on dockerhub now given your findings!

I find cleaning up unused things etc is relevant overall though. An accumulation of historic parts can be problematic, but not always. For example when its clear something is outdated its far better when its not clear. It can be quite clear that code only found in git history or a pypi release superseeded by a newer version is outdated, but its less clear if we have stopped pushing new versions of a docker image in favor of another name or similar.

I remember how finding the tljh-circleci image made me think tljh was tested like that still even though it wasn't - and that made me onboard myself to tljh's CI system a bit slower. Not a big deal, but I really appreciate complexity reduction whenever possible for reasons like that.

@minrk
Copy link
Member

minrk commented Sep 22, 2022

Thanks, I appreciate that perspective and all your efforts on reducing complexity and helping people contribute!

@consideRatio
Copy link
Member Author

I see that we have now got 10 members in the jupyterhub organization on hub.docker.com, maybe also for the jupyter organization then?

@consideRatio
Copy link
Member Author

@minrk are you an owner in the jupyter organization on hub.docker.com?

If so, could you confirm if we got 10 members allowed in the jupyter dockerhub organization at this point? I think we have! I'd like to help get @mathbunnyru access to help with jupyter/docker-stacks maintenance, for example to define the new proposed image repository in jupyter/docker-stacks#1809.

@parente
Copy link
Member

parente commented Nov 5, 2022

@mathbunnyru Is your Docker ID the same as your GitHub ID? If so, I can invite you.

@mathbunnyru
Copy link

@mathbunnyru Is your Docker ID the same as your GitHub ID? If so, I can invite you.

@parente yes! 👍

@parente
Copy link
Member

parente commented Nov 5, 2022

@mathbunnyru Invite sent.

@mathbunnyru
Copy link

mathbunnyru commented Nov 5, 2022

I accepted the invite, thank you! I guess you should also add me to the owners team, so I can create repositories.

Screenshot 2022-11-05 at 23 10 35

@mathbunnyru
Copy link

@parente could you take a look, please?

@mathbunnyru
Copy link

mathbunnyru commented Nov 8, 2022

@minrk @parente @rgbkrk could you please add me to the owners team?

@minrk
Copy link
Member

minrk commented Nov 9, 2022

@mathbunnyru added!

@consideRatio
Copy link
Member Author

I'll go for a close on this issue, its too large and we have resolved a lot of things already! Thanks everyone!!!

@mathbunnyru
Copy link

Thank you everyone for your help! I hope I will be able to help the community even better now.

@minrk
Copy link
Member

minrk commented Nov 9, 2022

Thanks @mathbunnyru for your extraordinary patience through this process!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants