Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically listing contributors #83

Open
betatim opened this issue Nov 14, 2018 · 6 comments
Open

Automatically listing contributors #83

betatim opened this issue Nov 14, 2018 · 6 comments

Comments

@betatim
Copy link
Member

betatim commented Nov 14, 2018

Sparked by my rant in #82: could we make a notebook like the one in the PR which fetches all the committers and people who have "replied to" more than one issue they didn't create?

I'd love to have an easy and automatic (with false positives) way of grabbing a list of people who help out but don't get counted in commit logs.

@choldgraf
Copy link
Member

I added a section to the jupyter activity report notebook here:

https://nbviewer.jupyter.org/github/choldgraf/jupyter-activity-snapshot/blob/master/templates/jupyter-activity-template.ipynb?flush_cache=true#List-of-all-contributors-per-organization

think we can iterate on that to grab the list of contributors over a period of time? (happy to either close this issue, or keep it open)

@choldgraf
Copy link
Member

choldgraf commented Nov 30, 2019

Is this something that we could use github-activity for?

E.g., if I run:

github-activity jupyterhub/team-compass --since 2019-11-01

I get:

Contributors for this release (commentors + issue/PR authors)

(GitHub contributors page for this release)

@arnim | @betatim | @bitnik | @choldgraf | @consideRatio | @GeorgianaElena | @lheagy | @manics | @willingc | @Zsailer


And just a reminder that here's a link to how github-activity defines contributions: https://github.com/choldgraf/github-activity#how-does-this-tool-define-contributions-in-the-reports

@betatim
Copy link
Member Author

betatim commented Dec 1, 2019

I like this suggestion!

Triggered by reading "commentors" and thinking "that is a weird word": should we remove the stuff in brackets in the header and just make it "Contributors for this release"?

@choldgraf
Copy link
Member

Yeah I’d be fine with that, I put it there to be a bit more explicit about what we mean, but maybe it’s enough to just link to the github activity repo section on defining contributors?

@betatim
Copy link
Member Author

betatim commented Dec 1, 2019

I am not even sure we need to be explicit about it. We know what we are doing is right. It might be different from what other projects do but hey, their loss :)

@choldgraf
Copy link
Member

fair enough - any chance you wanna make this a PR to github-activity? :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants