Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support markdown content #20

Open
fcollonval opened this issue May 10, 2021 · 1 comment
Open

Support markdown content #20

fcollonval opened this issue May 10, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@fcollonval
Copy link
Member

markdown. Being able to opt into some markdown (which might include
commandlinker links) for the step bodies would open a lot of opportunities

These last three kinda quack like "middleware," which could be registered
by plugins and opted into in a tour definition in the settings/command
API... As these would not be part of the official types, they'd need a new
place in the schema, e.g. "extras" or "transformers," e.g. {"markdown":
true, "xpath": true, "commands": true} at the simplest, though they might
need configuration...

Originally posted by @bollwyvl in #17 (comment)

@fcollonval fcollonval added the enhancement New feature or request label May 10, 2021
@bollwyvl
Copy link
Contributor

Thanks for splitting this out.

This is kind of a challenge, as likely a custom step component would be needed, with the Lab typesetting object handed down into its props, with some special sauce on componentDidMount, portals, or whatever. Ick. But would still feel really good. I hacked this with even ickier setTimeouts on @deathbeds/jupyterlab-rjsf and don't like it all, but in that case, there are markdownable fields all over (title, description), and i didn't want to make a full theme yet...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants