Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupyterlab 3 #14

Closed
quantum-booty opened this issue Sep 28, 2020 · 8 comments · Fixed by #19
Closed

Jupyterlab 3 #14

quantum-booty opened this issue Sep 28, 2020 · 8 comments · Fixed by #19

Comments

@quantum-booty
Copy link

Is there any plan to port this to the newly released Jupyterlab 3? Thank you!

@axelfahy
Copy link
Collaborator

There is a Jupyterlab 3 version? The last version I have is jupyterlab==2.2.8 and the plugin is running on this version.
I think there are some works in progress to integrate the vim support directly inside jupyterlab (jupyterlab/jupyterlab#8706). If this is not already the case with the next version, I will port it.

@quantum-booty
Copy link
Author

Thank you, the latest commit is a pre-alpha version of 3.0
It would amazing to have it integrated inside Jupyterlab :)

@lukashergt
Copy link

I think there are some works in progress to integrate the vim support directly inside jupyterlab (jupyterlab/jupyterlab#8706). If this is not already the case with the next version, I will port it.

Note that that PR got rebased and continued a few days ago in jupyterlab/jupyterlab#9068.

@ianhi
Copy link
Collaborator

ianhi commented Sep 29, 2020

Hiya, indeed it is now rebased and fully working + being reviewed. It stalled out for a while as the settings system was broken on jlab master which prevented working on it. I think an unfortunate consequence of this delay is that it may not land in version 3.0 as I expect they will not want to add new features at this point for fear of introducing bugs (but I could be wrong!). So we'll see what happens

@ianhi
Copy link
Collaborator

ianhi commented Oct 4, 2020

Hope springs eternal! From jupyterlab/jupyterlab#9068 (comment)

There is a slot to get this merged in 3.0. We have discussed a bit about this during our last weekly meeting

Plus I think the final release of 3.0 has been pushed back. So fingers cross all goes well

@ianhi
Copy link
Collaborator

ianhi commented Nov 23, 2020

Hiya,

Sorry for the long hiatus - I've been meaning to update this but life keeps getting in the way.

So I went to a few of the jlab dev meetings to discuss this and the conclusion was that integrating the vim keymap for the notebook is too big of a change to make for 3.0. However, there was general agreement that the current situation where keymap menu item only changes the file editor is a bad thing. So the plan is to work on including the notebook keymap in 3.1. Which is to say: The extension will need to be updated for 3.0 but as of 3.1 vim will likely be included in core.

As for updating:
With jlab3 there will be a new extension system ("federated extensions") that are distributed via pip and do not require a jupyter lab build step for end users. However, the old system (currently used by this extension) will continue to work fine.

So I guess it's up to @axelfahy whether to update to the new system (requires creating a package on pypi) or to continue with labextesion install and npm packages.

If we do go for the pip distribution then the one substantive change is that the extension needs to call ensureVimKeymap which I added in jupyterlab/jupyterlab#9161 to make sure that the jlab codemirror vim is loaded - webpack does some funky stuff I don't understand and imports from extensions will no longer affect jlab core in the same way - hence the new way of ensuring the vim keymap is loaded. You can see an example of this in jupyterlab-vimrc
https://github.com/ianhi/jupyterlab-vimrc/blob/6bb6e7cd0b5001009037ffbb728a153491d2196c/src/index.ts#L19-L25

@ianhi
Copy link
Collaborator

ianhi commented Nov 23, 2020

The other relevant open PR targeted at 3.1 is jupyterlab/jupyterlab#9142 which creates a way to track cell creation rather than when the active cell changes which would be nice for this extension

@ianhi
Copy link
Collaborator

ianhi commented Dec 11, 2020

PR upgrading this extension to work with jlab3 and be pip installable (no build step) is here: #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants