Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hatchling update script fights with jlpm lint #98

Closed
ianhi opened this issue Aug 1, 2023 · 0 comments · Fixed by #97
Closed

hatchling update script fights with jlpm lint #98

ianhi opened this issue Aug 1, 2023 · 0 comments · Fixed by #97

Comments

@ianhi
Copy link
Collaborator

ianhi commented Aug 1, 2023

running the workflow to update the version results in package.json being de-indented: 5203e7d#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519

but then jlpm lint throws an error on this.

Need to change either the lint rules or change how hatchling updates pcakage.json
@ianhi ianhi mentioned this issue Aug 1, 2023
Merged
@ianhi ianhi linked a pull request Aug 1, 2023 that will close this issue
fix: dev install + lint issues #97
Merged
@ianhi ianhi closed this as completed in #97 Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: dev install + lint issues ianhi/jupyterlab-vim
1 participant
@ianhi