Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

Closing the debugger when there is no active notebook throws an error #227

Closed
jtpio opened this issue Nov 25, 2019 · 0 comments · Fixed by #232
Closed

Closing the debugger when there is no active notebook throws an error #227

jtpio opened this issue Nov 25, 2019 · 0 comments · Fixed by #232
Assignees
@KsavinN
Labels
bug Something isn't working
Milestone
0.1.0

Comments

@jtpio
Copy link
Member

jtpio commented Nov 25, 2019

Closing the debugger when there is no active notebook throws an error.

This seems to be because we call the debug.stop() method when the model is disposed:

debugger/src/index.ts

Line 112 in 57951d6

await debug.stop();

Do we need to stop the debugger?

To reproduce:

  1. Open the debugger
  2. Open a notebook
  3. Close the notebook
  4. Close the debugger

debugger-close-no-notebook
@jtpio jtpio added this to the 0.1.0 milestone Nov 25, 2019
@jtpio jtpio added the bug Something isn't working label Nov 25, 2019
@KsavinN KsavinN self-assigned this Nov 26, 2019
@KsavinN KsavinN mentioned this issue Nov 26, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@KsavinN KsavinN

Labels
bug Something isn't working
Projects
None yet
Milestone
0.1.0
Development

Successfully merging a pull request may close this issue.

no throws error after close debugger KsavinN/debugger
2 participants
@jtpio @KsavinN