Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot send via keyboard after using slash command with an argument #849

Closed
dlqqq opened this issue Jun 21, 2024 · 1 comment · Fixed by #850
Closed

Cannot send via keyboard after using slash command with an argument #849

dlqqq opened this issue Jun 21, 2024 · 1 comment · Fixed by #850
Labels
bug Something isn't working

Comments

@dlqqq
Copy link
Collaborator

dlqqq commented Jun 21, 2024

Description

The 'Enter' key does not send the message after using a slash command with anything more than a single space after the slash command.

Reproduce

Screen.Recording.2024-06-21.at.7.51.29.AM.mov
@dlqqq dlqqq added the bug Something isn't working label Jun 21, 2024
@dlqqq
Copy link
Collaborator Author

dlqqq commented Jun 21, 2024 •
edited
Loading

This is due to the onHighlightChange being called with /ask after sending a slash command with arguments. Presumably this is because props.value gets set to an empty string "", which matches all options, causing the first option (/ask) to be highlighted. This sets the highlighted state var to true, which disables the Enter key.

highlighted should never be true if open is false. A PR implementing this change will fix this bug.

Screenshot 2024-06-21 at 8 14 49 AM

@dlqqq dlqqq mentioned this issue Jun 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix send via keyboard after sending slash command with arguments dlqqq/jupyter-ai
1 participant
@dlqqq