Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"RTC:" Prefix in Filename URL #183

Closed
la0bing opened this issue Aug 11, 2023 · 8 comments
Closed

"RTC:" Prefix in Filename URL #183

la0bing opened this issue Aug 11, 2023 · 8 comments
Labels
bug Something isn't working

Comments

@la0bing
Copy link

la0bing commented Aug 11, 2023

Description

With both jupyter-collaboration and jupyter_scheduler extensions installed, jupyter_scheduler will detect notebook.ipynb as RTC:notebook.ipynb which causes jupyter_scheduler failing to find the file in path, the file path URL will also look something like this: "localhost:8080/user/user1/lab/tree/RTC%3Anotebook.ipynb"

Weirdly I also noticed "RTC:" in the launcher tab as well.

Reproduce

  1. Install the following libraries in Python 3.11.4
conda install jupyter-collaboration=1.0.1
pip install jupyter_scheduler==2.0.0 jupyterlab==4.0.4
  1. Start jupyterlab with
jupyter lab

Expected behavior

Filename to not be changed and "RTC:" prefix not showing in launcher tab.

Context

  • Operating System and version: MacOS Ventura 13.4
  • Browser and version: Edge 114.01823.82
  • JupyterLab version: 4.0.4
Troubleshoot Output
Paste the output from running `jupyter troubleshoot` from the command line here.
You may want to sanitize the paths in the output.
Command Line Output
Paste the output from your command line running `jupyter lab` here, use `--debug` if possible.
Browser Output image
@la0bing la0bing added the bug Something isn't working label Aug 11, 2023
@welcome
Copy link

welcome bot commented Aug 11, 2023

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@lrlunin
Copy link

lrlunin commented Aug 11, 2023

I guess the same problem underlies this bug in jupyterlab-h5web-viewer.

@f14h
Copy link

f14h commented Aug 29, 2023

This also breaks the File->Export feature to download the notebook as pdf, html, latex, ... nbconvert does not find the file with the attached "RTC:"

@martinRenou
Copy link
Member

This issue is not an issue with jupyter-collaboration, it is most likely jupyter_scheduler that does not support custom drives. Same comment for jupyterlab-h5web and the file export feature in core-jupyterlab.

You may see similar incompatibilities with https://github.com/jupyterlab-contrib/jupyterlab-filesystem-access or https://github.com/jupyterlab/jupyterlab-github which also provide custom drives.

@la0bing
Copy link
Author

la0bing commented Aug 29, 2023

@martinRenou sorry I am not really familiar with the extension itself, what do you mean by custom drives here? As I just am using the docker stacks from jupyter as is with those 2 extra extensions, also weirdly when i remove the "RTC%3A" part from the url and reload the page, I am able to somehow workaround and use the scheduler as normal.

@martinRenou
Copy link
Member

A custom Drive is a feature of the content manager in JupyterLab that allows you to extend file management (e.g. jupyterlab-github uses it to give access in the JupyterLab filebrowser to files that lives on a Github repository). This feature is used across multiple extensions, like jupyterlab-collaboration, but it's not well supported by some extensions. Even JupyterLab itself did not support custom drives very well, hence the file > export issue mentioned above.

So my point is that an issue should be reported to the jupyterlab-scheduler that custom drives are not supported, it should be fixed there. There is nothing we can do in jupyterlab-collaboration.

@hbcarlos
Copy link
Member

hbcarlos commented Sep 4, 2023

Thanks for the answer @martinRenou!

As @martinRenou commented above, this is fine in jupyter-collaboration. Most extensions and some code in core JupyterLab didn't know about custom drives because the default drive doesn't have a prefix (for example, "RTC:"). This issue should be fixed on those extensions.

@loichuder
Copy link

@martinRenou Thanks for the explanation.

I guess JupyterLab has abstractions to deal with custom drives ? Or, is there some documentation or examples to follow for extension maintainers to deal with these consistently ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants