-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"RTC:" Prefix in Filename URL #183
Comments
Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗 |
I guess the same problem underlies this bug in jupyterlab-h5web-viewer. |
This also breaks the File->Export feature to download the notebook as pdf, html, latex, ... nbconvert does not find the file with the attached "RTC:" |
This issue is not an issue with jupyter-collaboration, it is most likely You may see similar incompatibilities with https://github.com/jupyterlab-contrib/jupyterlab-filesystem-access or https://github.com/jupyterlab/jupyterlab-github which also provide custom drives. |
@martinRenou sorry I am not really familiar with the extension itself, what do you mean by custom drives here? As I just am using the docker stacks from jupyter as is with those 2 extra extensions, also weirdly when i remove the "RTC%3A" part from the url and reload the page, I am able to somehow workaround and use the scheduler as normal. |
A custom Drive is a feature of the content manager in JupyterLab that allows you to extend file management (e.g. jupyterlab-github uses it to give access in the JupyterLab filebrowser to files that lives on a Github repository). This feature is used across multiple extensions, like jupyterlab-collaboration, but it's not well supported by some extensions. Even JupyterLab itself did not support custom drives very well, hence the file > export issue mentioned above. So my point is that an issue should be reported to the jupyterlab-scheduler that custom drives are not supported, it should be fixed there. There is nothing we can do in jupyterlab-collaboration. |
Thanks for the answer @martinRenou! As @martinRenou commented above, this is fine in jupyter-collaboration. Most extensions and some code in core JupyterLab didn't know about custom drives because the default drive doesn't have a prefix (for example, "RTC:"). This issue should be fixed on those extensions. |
@martinRenou Thanks for the explanation. I guess JupyterLab has abstractions to deal with custom drives ? Or, is there some documentation or examples to follow for extension maintainers to deal with these consistently ? |
Description
With both
jupyter-collaboration
andjupyter_scheduler
extensions installed,jupyter_scheduler
will detectnotebook.ipynb
asRTC:notebook.ipynb
which causesjupyter_scheduler
failing to find the file in path, the file path URL will also look something like this: "localhost:8080/user/user1/lab/tree/RTC%3Anotebook.ipynb"Weirdly I also noticed "RTC:" in the launcher tab as well.
Reproduce
Expected behavior
Filename to not be changed and "RTC:" prefix not showing in launcher tab.
Context
Troubleshoot Output
Command Line Output
Browser Output
The text was updated successfully, but these errors were encountered: