Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook with embedded vega-lite output doesn't show properly #92

Closed
davidanthoff opened this issue Jan 31, 2018 · 5 comments
Closed

Notebook with embedded vega-lite output doesn't show properly #92

davidanthoff opened this issue Jan 31, 2018 · 5 comments

Comments

@davidanthoff
Copy link

I'm trying to use the built-in vega-lite support for the julia VegaLite.jl package. Through a lot of hoops I managed to create this notebook file. Don't try to run the code in that notebook, that part only works if you have a whole number of unreleased branches checked out on the julia side of things.

BUT, at the end of the day, I would have expected that if this notebook file just gets opened in jupyterlab with the vega3 extension installed, that it would show the vega-lite plot. The second cell does have a data field that has the mime type application/vnd.vegalite.v2+json, and inside there it does have a valid vega-lite 2 spec, so shouldn't this show the graph if I just open that file in jupyterlab?

I am suspecting that I'm doing something wrong because it also doesn't show in nteract.

Any pointers would be greatly appreciated!

@domoritz
Copy link
Member

domoritz commented Jan 31, 2018

It's awesome to hear that you are working on VegaLite.jl. I'm happy to help as much as I can.

Can you compare your notebook with https://github.com/jupyterlab/jupyter-renderers/blob/master/notebooks/vega3-extension.ipynb? Does the notebook work for you?

@davidanthoff
Copy link
Author

Ah, that is super helpful! When I open that, everything looks the way it should. And there is a key difference between what I generated and that file: in my case the vega-lite spec is inside a string, whereas in the file that works the JSON from the vega-lite spec is just part of the notebook JSON. So, I just have to figure out how to get that kind of output and we might be good. I'll report back.

@davidanthoff
Copy link
Author

Alright, just waiting for JuliaLang/IJulia.jl#621 to be merged, and then it should all be good.

@domoritz
Copy link
Member

🎉

@davidanthoff
Copy link
Author

davidanthoff commented Feb 3, 2018

Ok, now all working end-to-end :) Thanks for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants