Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JavaScript and lab extension test in CI #144

Merged
merged 5 commits into from
May 2, 2023

Conversation

fcollonval
Copy link
Member

@fcollonval fcollonval commented May 2, 2023

Code changes

Add test for installing the extension and the frontend proving current code is broken

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2023

Binder 👈 Launch a Binder on branch fcollonval/jupyter_server_ydoc/fix/ydocs

@fcollonval fcollonval changed the title Fix jupyter_ydoc import Add JavaScript and lab extension test in CI May 2, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 2, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (65a6bc6) 0.00% compared to head (03814b9) 0.00%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #144   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          7       7           
  Lines        453     453           
=====================================
  Misses       453     453           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fcollonval fcollonval marked this pull request as ready for review May 2, 2023 17:17
@fcollonval
Copy link
Member Author

Merging as is as it does not change any code but add fail safe for follow-up bug hunting work.

@fcollonval fcollonval merged commit 08df151 into jupyterlab:main May 2, 2023
17 checks passed
@fcollonval fcollonval deleted the fix/ydocs branch May 2, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants