Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix injecting user menu bar in top bar. #149

Merged
merged 2 commits into from
May 15, 2023

Conversation

fcollonval
Copy link
Member

The user menu bar was having mixed configuration giving the impression it is injected in the top bar through the toolbar registry when it was not.

This fixes it.

@fcollonval fcollonval added the bug Something isn't working label May 10, 2023
@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch fcollonval/jupyter_server_ydoc/fix/menu-in-topbar

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (1cb07c8) 0.00% compared to head (232db17) 0.00%.

❗ Current head 232db17 differs from pull request most recent head 35734b8. Consider uploading reports for the commit 35734b8 to get more accurate results

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #149   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          7       7           
  Lines        453     453           
=====================================
  Misses       453     453           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@hbcarlos hbcarlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fcollonval!

@hbcarlos hbcarlos merged commit 4b587b7 into jupyterlab:main May 15, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants