-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support file types #154
Support file types #154
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #154 +/- ##
==========================================
- Coverage 42.77% 41.42% -1.36%
==========================================
Files 8 8
Lines 519 548 +29
Branches 73 75 +2
==========================================
+ Hits 222 227 +5
- Misses 293 317 +24
Partials 4 4
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hbcarlos.
LGTM apart from the linter and the type checks.
52d1c2b
to
0e03df2
Compare
Thanks @hbcarlos for the fix, can we get a new release with this PR? |
🚀 |
@trungleduc It is done. Can you try it out? There was an error during the release, and I had to publish the PyPi package manually. https://github.com/jupyterlab/jupyter_collaboration/releases/tag/v1.0.0alpha9 |
@fcollonval I tried to publish a new alpha with the release but could not. It failed while publishing the PyPi package. It looks like the jupyter_collaboration project is under the Jupyter organization on PyPi, and my token is not valid anymore. See: I tried to create a new token with a different scope, but I could not. I'm not sure if it is because I'm not part of the Jupyter org in PyPi or how we should publish the package now. |
Fixes QuantStack/glue-jupyterlab#43