Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support file types #154

Merged
merged 2 commits into from
May 30, 2023
Merged

Conversation

hbcarlos
Copy link
Member

@hbcarlos hbcarlos added the bug Something isn't working label May 24, 2023
@hbcarlos hbcarlos self-assigned this May 24, 2023
@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch hbcarlos/jupyter_collaboration/support_custom_file_types

@codecov-commenter
Copy link

codecov-commenter commented May 24, 2023

Codecov Report

Patch coverage: 25.00% and project coverage change: -1.36 ⚠️

Comparison is base (94fcd92) 42.77% compared to head (efed586) 41.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #154      +/-   ##
==========================================
- Coverage   42.77%   41.42%   -1.36%     
==========================================
  Files           8        8              
  Lines         519      548      +29     
  Branches       73       75       +2     
==========================================
+ Hits          222      227       +5     
- Misses        293      317      +24     
  Partials        4        4              
Impacted Files Coverage Δ
jupyter_collaboration/handlers.py 26.21% <0.00%> (-1.00%) ⬇️
jupyter_collaboration/rooms.py 20.80% <10.00%> (-2.51%) ⬇️
jupyter_collaboration/loaders.py 75.96% <33.33%> (-1.71%) ⬇️
jupyter_collaboration/utils.py 86.36% <100.00%> (+5.11%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@davidbrochart davidbrochart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hbcarlos.
LGTM apart from the linter and the type checks.

jupyter_collaboration/loaders.py Outdated Show resolved Hide resolved
jupyter_collaboration/rooms.py Outdated Show resolved Hide resolved
jupyter_collaboration/rooms.py Show resolved Hide resolved
jupyter_collaboration/rooms.py Show resolved Hide resolved
@davidbrochart davidbrochart merged commit fbae4ff into jupyterlab:main May 30, 2023
18 checks passed
@hbcarlos hbcarlos deleted the support_custom_file_types branch May 30, 2023 09:23
@trungleduc
Copy link
Member

Thanks @hbcarlos for the fix, can we get a new release with this PR?

@martinRenou
Copy link
Member

🚀

@hbcarlos
Copy link
Member Author

@trungleduc It is done. Can you try it out? There was an error during the release, and I had to publish the PyPi package manually.

https://github.com/jupyterlab/jupyter_collaboration/releases/tag/v1.0.0alpha9

@hbcarlos
Copy link
Member Author

@fcollonval I tried to publish a new alpha with the release but could not. It failed while publishing the PyPi package. It looks like the jupyter_collaboration project is under the Jupyter organization on PyPi, and my token is not valid anymore. See:
https://github.com/hbcarlos/jupyter_releaser/actions/runs/5120015846/jobs/9205992914#step:6:204

I tried to create a new token with a different scope, but I could not. I'm not sure if it is because I'm not part of the Jupyter org in PyPi or how we should publish the package now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Session file is not save after moving view between tabs
5 participants