Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style of file list #227

Closed
jennalandy opened this issue Sep 1, 2018 · 7 comments
Closed

Style of file list #227

jennalandy opened this issue Sep 1, 2018 · 7 comments

Comments

@jennalandy
Copy link
Contributor

Suggestions for style changes to file list

  • Add file path to each line
  • Change trash icon for deleting changes. consider material design undo (https://www.materialui.co/icon/undo)
  • Consistent margins
  • Right align track/untrack/stage/unstage/delete buttons
@ellisonbg
Copy link
Contributor

VS Code does a good job of showing all the relevant information in the list of changed files.

@weihwang
Copy link

weihwang commented Oct 16, 2018

Proposed changes to file list for commit:
https://www.figma.com/file/UyNpeQNuTj6Uv74MoEJDh3ji/Git-extension?node-id=606%3A2205

  • margin
  • right-aligned actions
  • right-aligned status for consistency with file browser view

image

@weihwang
Copy link

@jaipreet-s this is the closest issue for the right-align icon actions.

@weihwang weihwang mentioned this issue Oct 19, 2018
2 tasks
@tgeorgeux
Copy link
Contributor

tgeorgeux commented Oct 19, 2018

The only issue I see here as of now is the red doesn't show up great in dark view. Any thoughts on that? (To clarify I mean the text, not the icon.

@weihwang
Copy link

I think we can find a color for red that is visible on both. As an alternative we can rely on the strikethrough styling too. I'll test this out.

@jaipreet-s
Copy link
Member

@weihwang thanks! Tagging this to the 0.5 release.

@jaipreet-s jaipreet-s added this to the 0.5 milestone Oct 19, 2018
@fcollonval fcollonval removed this from the 0.5 milestone Oct 19, 2019
@telamonian telamonian added this to the Future milestone Dec 5, 2019
@fcollonval
Copy link
Member

Closing this issue as the styles in 0.10.0 fit this proposal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants