Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discard changes fails due to index.lock already exists #555

Closed
lresende opened this issue Mar 8, 2020 · 2 comments
Closed

Discard changes fails due to index.lock already exists #555

lresende opened this issue Mar 8, 2020 · 2 comments

Comments

@lresende
Copy link
Member

lresende commented Mar 8, 2020

Description

Discard changes fails due to index.lock already exists

Reproduce

  1. Go to a directory that represents cloned git repository

  2. Make changes to a given file

  3. Click on the icon to pull from the repository
    image

  4. Now, try go discard the changes in order to be able to pull from the repository
    image

  5. Discard fails due to index.lock is already present
    image

Expected behavior

Discard should discard the changes for the file

Context

  • Python package version:
    • JupyterLab 1.2.7
    • Jupyterlab-git master

Workaround

It seems that on the second try it actually behaves well, needs to investigate it further.

@lresende
Copy link
Member Author

lresende commented Mar 8, 2020

This seems related to the following git config in my environment

[branch]
        autosetuprebase = always

Maybe we could check for this and decide if we should use git merge --abort versus git rebase --abort

@fcollonval
Copy link
Member

This should be fixed by #564

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants