Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide feedback on git command execution #601

Closed
fcollonval opened this issue Apr 20, 2020 · 3 comments · Fixed by #630
Closed

Provide feedback on git command execution #601

fcollonval opened this issue Apr 20, 2020 · 3 comments · Fixed by #630

Comments

@fcollonval
Copy link
Member

This is a follow-up of #564.

Proposal:

  1. Allow retry timeout configurability for acquiring the index.lock.
  2. Suspend UI interactions until pending command complete (e.g., a modal with a spinner). I believe this should be straightforward, as we just need to enable a UI element until receiving an HTTP response.

The need for the latter is to prevent/dissuade the user from closing the JupyterLab server before pending commands have had a chance to complete (e.g., before an index.lock file is removed and git add && git commit run, thus potentially leading to the discarding of user changes).

Originally posted by @kgryte in #564 (comment)

@kgryte
Copy link
Member

kgryte commented Apr 30, 2020

Assigning myself. Am currently working on this.

@kgryte kgryte self-assigned this Apr 30, 2020
@jaipreet-s
Copy link
Member

I'm not sure if any UX discussions have happened around this, but the JupyterLab Status Bar is a candidate for to notify the user that an async background process is running, without having a dialog blocking their view.

(JFYI the Status Bar was not present in JL core while many of these Git actions were implemented)

@kgryte
Copy link
Member

kgryte commented Apr 30, 2020

Thanks for the suggestion. I'd still lean toward using a backdrop or other UI element to prevent further user action. The main impetus for this is to guard against the "race condition" of a user ending the server process before commands have finished executing. A status bar indicator is unlikely to dissuade users from prematurely doing so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants