Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML inline style not shown in trusted notebook's markdown cell #11473

Closed
ghost opened this issue Nov 16, 2021 · 6 comments · Fixed by #11510
Closed

HTML inline style not shown in trusted notebook's markdown cell #11473

ghost opened this issue Nov 16, 2021 · 6 comments · Fixed by #11510
Labels
bug status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.

Comments

@ghost
Copy link

ghost commented Nov 16, 2021

Reproduce

  • Open jupyterlab v3.2.3, create a new notebook and add a markdown cell:
<span style="font-size:42px">Irrelavant text.</span>

Expected behavior

html should be rendered correctly just like in latest jupyter notebook v6.4.5

@ghost ghost added the bug label Nov 16, 2021
@welcome
Copy link

welcome bot commented Nov 16, 2021

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@krassowski
Copy link
Member

krassowski commented Nov 16, 2021

Thank you for reporting, this is indeed a regression. It worked well in version 3.2.1 and stopped working in 3.2.2. We need to start testing rendering of styled elements in Markdown in the visual regression testing.

I could not narrow it down to any of the PR backports, and I do not see it it on the master either. This is odd.

@meeseeksmachine
Copy link
Contributor

This issue has been mentioned on Jupyter Community Forum. There might be relevant details there:

https://discourse.jupyter.org/t/style-attributes-in-markdown-cells/11761/2

@drewyoungren
Copy link

The same effect can be seen in the regular markdown previewer starting with 3.2.2 as well.

image

@krassowski
Copy link
Member

This could be because of an upstream bug in sanitize-html: apostrophecms/sanitize-html#510

@krassowski
Copy link
Member

krassowski commented Nov 20, 2021

That bug was already fixed in sanitize-html 2.5.3 by removing klona. Now, we did not have any update of sanitize-html recently but an update of klona broke this for us, so we need to pin klona to 2.0.4 or upgrade sanitize-html to 2.5.3. This klona version update happened in the 3.2.2 release indeed.

@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label May 22, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants