Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupyter Theme: Sync setting light or dark theme with OS setting #12988

Open
kiryph opened this issue Aug 23, 2022 · 2 comments
Open

Jupyter Theme: Sync setting light or dark theme with OS setting #12988

kiryph opened this issue Aug 23, 2022 · 2 comments

Comments

@kiryph
Copy link

kiryph commented Aug 23, 2022

Problem

  • I'm always disappointed when JupyterLab does not automatically change from light to dark theme when it's getting late and macOS switches to the dark system theme. Almost all apps and many Websites respond to the theme change (e.g. github.com, stackoverflow.com, ...).

Here a screenshot from github.com:

Screenshot 2022-08-23 at 07 21 47

Proposed Solution

  • Add an option to menu Settings → Theme → “Sync with system”
@welcome
Copy link

welcome bot commented Aug 23, 2022

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@jupyterlab-probot jupyterlab-probot bot added the status:Needs Triage Applied to new issues that need triage label Aug 23, 2022
@jtpio
Copy link
Member

jtpio commented Aug 23, 2022

Thanks @kiryph for opening this issue, it would indeed be a great feature.

It sounds similar to this one: #8777.

Let's close in favor of #8777 and continue the conversation there?

@jtpio jtpio added status:Duplicate and removed status:Needs Triage Applied to new issues that need triage labels Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants