Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI broken #13082

Closed
fcollonval opened this issue Sep 13, 2022 · 4 comments · Fixed by #13084
Closed

CI broken #13082

fcollonval opened this issue Sep 13, 2022 · 4 comments · Fixed by #13084
Labels
bug maintenance status:Needs Triage Applied to new issues that need triage
Milestone

Comments

@fcollonval
Copy link
Member

Description

Since a day or so, the CI is broken.

The pathologic error seen are:
For JS tests when running jlpm run build

error TS2688: Cannot find type definition file for 'node'.
  The file is in the program because:
    Entry point of type library 'node' specified in compilerOptions
Error: ../observables/src/observablemap.ts(4,29): error TS2307: Cannot find module '@lumino/disposable' or its corresponding type declarations.

For other tests

$ node scripts/ensure-buildutils.js && node buildutils/lib/ensure-repo.js --force
internal/modules/cjs/loader.js:905
  throw err;
  ^

Error: Cannot find module 'fs-extra'
Require stack:
- /home/runner/work/jupyterlab/jupyterlab/scripts/ensure-buildutils.js
sh: 1: prettier: not found

etc

See for example https://github.com/jupyterlab/jupyterlab/pull/12899/checks

By curiosity I ran a second time the JS tests on the last master commit that passed and it failed (you can see it by switching from attempt 1 and attempt 2): https://github.com/jupyterlab/jupyterlab/actions/runs/3035624109

This calls for an external impact - certainly related to the pip install -e .[dev,test] that does not run jlpm install on the current folder.

@fcollonval fcollonval added bug status:Needs Triage Applied to new issues that need triage maintenance labels Sep 13, 2022
@fcollonval
Copy link
Member Author

In the rerun of the last working commit, the Installation dependencies took 1m40s in the failing case and 5m56s in the working one. Also in the working case there are multiple line Building editable for jupyterlab (pyproject.toml): still running... when there is only one in the failing case.

A candidate is the latest release of https://github.com/jupyterlab/hatch-jupyter-builder

@fcollonval
Copy link
Member Author

fcollonval commented Sep 13, 2022

Another candidate is hatchling v1.9.0: https://github.com/pypa/hatch/releases/tag/hatchling-v1.9.0

@fcollonval
Copy link
Member Author

fcollonval commented Sep 13, 2022

Some discrepancy seen with hatch-jupyter-builder.

With version 0.5.3, pip install -e triggers: hatch_jupyter_builder.utils:With kwargs: {'build_cmd': 'build', 'source_dir': 'packages', 'build_dir': 'dev_mode/static', 'npm': ['node', 'jupyterlab/staging/yarn.js']}
With version 0.6.1 (0.6.0 was not published apparently), it triggers: hatch_jupyter_builder.utils:With kwargs: {'build_cmd': 'build:prod:minimize', 'path': 'jupyterlab/staging', 'source_dir': 'jupyterlab/staging', 'build_dir': 'jupyterlab/static', 'npm': ['node', 'yarn.js']}

@fcollonval
Copy link
Member Author

A fix proposal has been opened upstream: jupyterlab/hatch-jupyter-builder#68

@fcollonval fcollonval added this to the 4.0.0 milestone Sep 13, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug maintenance status:Needs Triage Applied to new issues that need triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant