Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add announcement feature #13110

Closed
Tracked by #13064
fcollonval opened this issue Sep 21, 2022 · 1 comment · Fixed by #13365
Closed
Tracked by #13064

Add announcement feature #13110

fcollonval opened this issue Sep 21, 2022 · 1 comment · Fixed by #13365

Comments

@fcollonval
Copy link
Member

fcollonval commented Sep 21, 2022

Problem

Add a way to send announcement to our user database.

The goal is to reach out to more users directly within the software rather than through our communication channel (gitter, discourse, GitHub,...).

This is not about gathering data from our users.

Proposed Solution

  • Serve statically a JSON file in a GitHub repository within the JupyterLab organization.
    • We can enforce PR rules to update that announcement like having two accepted reviews as a firewall.
    • Using such way, we will not record any information from user requests.
  • Fetch from the server that announcement file.
    • The statically fetch JSON URL will be configurable and will deactivate the feature if set to None.
    • The final implementation uses the Atom feed XML format.
  • Display notifications with the current announcements in the frontend.
    • This will be in its own plugin to be disabled if required

Additional context

Prior art:

@bollwyvl
Copy link
Contributor

If such a thing as this landed, it's probably worth it to consider all the external requests that might be generated here and elsewhere (e.g. extension managers talking to package upstreams, help pages that call out, and any CDN requests) and have a "big red button," which can gate access to what can be contacted, making it easy to say, *, don't make any requests.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants