-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore autosave ? #335
Comments
Spit-balling: We should create checkpoints for all documents from the context manager whenever we save, and have it create checkpoints for all open files periodically. When we load a file, check for a checkpoint before getting the disk contents. |
Okay, I had misinterpreted what a checkpoint is. They were created only when created explicitly saving. The file itself is auto-saved (but only notebooks previously). I am going to bring this up at the meeting today. I propose that we emulate what a desktop editor would do: aggressively save to a temporary file that can be recovered, and have a setting for an auto save interval to disk. "Checkpointing" should be done using version control. We should also periodically check for a file change on disk and ask to revert. |
The current behavior, modeled on modern applications and the norm for web applications, was picked specifically as opposed to the behavior of apps like word and emacs, which necessitates unpleasant things like recovery dialogs, timestamp comparisons etc., the triggers for which are all much more likely to happen in a browser app than a regular desktop application. With server-side document state, I don't think we would need necessarily need autosave anymore, because the browser is no longer the sole home for unsaved state. |
Message received :). I'll follow the IPEP. |
Note that the IPEP apply to the notebook only, but I think consistency is important. I thought agree that is is less than optimal, and agree that a server-side state would be much better. |
Bumping that please, I again lost 30 min of work because of a new "go to previous page" chrome shortcut [Ctrl+LeftArrow] |
Yep, this is first on my list when I get back. Also note you can disable that behavior on OSX at least. |
The fact the jupyterlab does have the ability to prevent closing phosphor tabs and save notebook is great, though other things can happen like network connection down... etc, and a few time I've close JupyterLab withhout saving, with habit of normal notebook.
Can we re-enable, or speedup the delay between autosave?
The text was updated successfully, but these errors were encountered: