Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add and use CSS variables for box shadows/elevation #3464

Closed
ellisonbg opened this issue Dec 22, 2017 · 0 comments · Fixed by #3468
Closed

Add and use CSS variables for box shadows/elevation #3464

ellisonbg opened this issue Dec 22, 2017 · 0 comments · Fixed by #3468
Labels
enhancement pkg:themes status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone
0.31.0

Comments

@ellisonbg
Copy link
Contributor

Right now all of our box shadows are hard coded. We are mostly trying to use the Material Design elevation idea for our box shadows. It would really help to have CSS variables for different elevations of box shadow, for both light and dark theme. Marking as beta, but this can land during the rc cycle.
@ellisonbg ellisonbg added this to the Beta milestone Dec 22, 2017
@ellisonbg ellisonbg mentioned this issue Dec 23, 2017
Merged
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Aug 9, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement pkg:themes status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Milestone
0.31.0
Development

Successfully merging a pull request may close this issue.

Elevation based shadows and CSS variables ellisonbg/jupyterlab
1 participant
@ellisonbg