Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to add a button to file browser. (Git Extension Support 1/2) #5498

Closed
tgeorgeux opened this issue Oct 15, 2018 · 2 comments
Closed
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.

Comments

@tgeorgeux
Copy link
Contributor

tgeorgeux commented Oct 15, 2018

For the Git Extension, we're trying to integrate the experience with the existing file browser. The first order of business was to add a 'clone repo' button to the file browser. I was wondering what it would take to expose the API for the file browser so an extension could do something like this (Red outline is there to highlight the new feature, I'm not looking to add a bright red outline to the UI):
screen shot 2018-10-15 at 9 27 45 am

cc: @jaipreet-s , @weihwang

@jaipreet-s
Copy link
Member

This is do-able in a fairly clean way today without having to resort to DOM manipulation

A plugin can request an IFileBrowserFactory, access the toolbar element, and add a ToolbarButton

let toolbar = factory.defaultBrowser.toolbar;
 toolbar.addItem('myButton', new ToolbarButton({...});

@ian-r-rose
Copy link
Member

Thanks @jaipreet-s

@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Aug 8, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

No branches or pull requests

3 participants