Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: Avoid dialog box to say "Directory not found" #6782

Open
consideRatio opened this issue Jul 8, 2019 · 2 comments
Open

UX: Avoid dialog box to say "Directory not found" #6782

consideRatio opened this issue Jul 8, 2019 · 2 comments

Comments

@consideRatio
Copy link
Member

I'm often removing a folder from terminal that I'm browsing in the view to he left, and after some seconds of delay I end up with a dialog box that I need to dismiss before continuing to do work in the terminal. I'm not sure what to do instead, but similar to many applications decides to show "connection lost" as a status bar or similar rather than a dialog popup, I think it would be suitable to show the "Directory not found" not as a modal dialog, but as some status within the content manager to the left.

GIF animation of the UX in Jupyter Lab 0.35.6

remove-dir-we-are-within

@krassowski
Copy link
Member

This is reproducible in 1.0.2. An alternative to the proposed solution would be to use a toast notification (see #6389) once merged instead of the modal; the toast might be better as it is still exposed to the user and thus might minimize confusion in a scenario when the directory was removed (or moved) by another process (i.e. not intentionally by the user as shown above).

@consideRatio
Copy link
Member Author

A good improvement from whats seen here in Jupyter Lab 1.0.1 is that the content manager leaves the folder, so the dialog box will only show once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants