Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for custom icons in 1.1 #7142

Closed
jtpio opened this issue Sep 3, 2019 · 1 comment
Closed

Documentation for custom icons in 1.1 #7142

jtpio opened this issue Sep 3, 2019 · 1 comment
Labels
documentation status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:CSS For general CSS related issues and pecadilloes tag:Extensions

Comments

@jtpio
Copy link
Member

jtpio commented Sep 3, 2019

There doesn't seem to be any documentation yet on how to add custom icons from third-party extensions, using the new iconRegistry introduced in 1.1.

import iconSvg from '../style/icon.svg';
defaultIconRegistry.addIcon({name: 'icon', svg: iconSvg})

Upgrading from 1.0 to 1.1 also seems to be breaking toolbar icons (they are not shown anymore) when third-party extensions define their icons directly in CSS with background-image.

It would be great to add a few points to the docs explaining how to:

  • add custom icons to the registry
  • add them to toolbars
  • handle themes
@jtpio jtpio added tag:CSS For general CSS related issues and pecadilloes documentation tag:Extensions labels Sep 3, 2019
@jtpio
Copy link
Member Author

jtpio commented Sep 1, 2020

@jtpio jtpio closed this as completed Sep 1, 2020
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Mar 1, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:CSS For general CSS related issues and pecadilloes tag:Extensions
Projects
None yet
Development

No branches or pull requests

1 participant