Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-evaluate sideEffects flag values #7196

Open
vidartf opened this issue Sep 12, 2019 · 0 comments
Open

Re-evaluate sideEffects flag values #7196

vidartf opened this issue Sep 12, 2019 · 0 comments

Comments

@vidartf
Copy link
Member

vidartf commented Sep 12, 2019

I recently read in the webpack docs on tree shaking:

components/Breadcrumbs.js: No export is used, not flagged with sideEffects -> exclude it. This also excluded all dependencies like components/Breadcrumbs.css even if they are flagged with sideEffects.

The current values for sideEffects set in our package.json files assumed that imports from a file would be checked independently for side effects, due to previous wording in the docs (mea culpa). As such, we should change to only use sideEffects if we are sure that nothing in that package/file, nor its dependencies, have side effects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant