Multiple terminal support

[andyrobreid]

Problem

Multiple terminal support, currently I'm only aware that you can configure what terminal is executed via c.LabApp.terminado_settings={'shell_command':[<command>]} jupyter_notebook_config.py setting.

If I wish to use bash instead of PowerShell I have to change the config and restart Jupyter lab.

Proposed Solution

Ability to configure multiple terminals, having configurable properties shell_command, name, icon_path (icon request)

Additional context

Here is a discussion regarding the request.

[meeseeksmachine]

This issue has been mentioned on Jupyter Community Forum. There might be relevant details there:

https://discourse.jupyter.org/t/multiple-terminal-shells-in-jupyterlab/3261/5

[dhirschfeld]

Related: #4034

[dhirschfeld]

Also, jupyter/notebook#3262

[andyrobreid]

Also, jupyter/notebook#3262

Didn't think to look through the notebook repo issues. Thanks

[cameron-toy]

Would the client or server be choosing the terminal application? It seems like it could be a security issue if the client can choose an arbitrary program to use as the terminal.

[dhirschfeld]

I fail to see how it could be a security issue if the user can simply open a terminal and run any arbitrary program they want in any case?

If somehow it is still a concern (maybe terminals are disallowed for that reason) it could be mitigated by a c.ServerApp.terminals.allow_list configuration