Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport initial page load performance improvements to JL 1.2.x #9870

Open
reesscot opened this issue Feb 24, 2021 · 0 comments
Open

Backport initial page load performance improvements to JL 1.2.x #9870

reesscot opened this issue Feb 24, 2021 · 0 comments

Comments

@reesscot
Copy link

Problem

  • I'm trying to make JupyterLab 1.2 load faster on initial page load and I've seen that a number of improvements have been made in JupyterLab 3.0 to split the vendors~main.js (JL 1.2) file into multiple bundles. In particular I noticed that there is now a jlab_core bundle. I tried backporting this to 1.2 and it reduced the size of vendors~main.js by about 1.5 MB.

JL 3.0 webpack cacheGroups

optimization: {
      splitChunks: {
        chunks: 'all',
        cacheGroups: {
          jlab_core: {
            test: /[\\/]node_modules[\\/]@(jupyterlab|lumino)[\\/]/,
            name: 'jlab_core'
          }
        }
      }
    },

Proposed Solution

  • I would like to submit a PR to backport bundle splitting optimizations from JL 3.0. However, are there other Webpack changes in 3.0 besides the jlab_core bundle that I missed? I also noticed that 3.0 is splitting the node_modules dependencies into separate bundles as well.

Additional context

JL 3.0 assets optimization (DevTools Performance)
Screen Shot 2021-02-24 at 9 01 53 AM

JL 1.2 with jlab_core cache group backported from 3.0. (DevTools Performance)
Screen Shot 2021-02-24 at 9 01 40 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant