-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Debugger] Treat user variable filter settings as a mergable add-on #9903
Comments
I think most of the current defaults should actually be moved to the backend, because there are kernel specific. |
It's also worth noting that jupyterlab/packages/debugger-extension/schema/main.json Lines 39 to 52 in b13cc05
Under |
Slightly off-topic, but just to spell this out, it appears that the defaults for
which was not the case for older versions of xeus-python (I believe it has to do with the rework of xeus-python to be more closely tied to IPython). I might be wrong though, I don't know a lot about the debugger. Could these filters become regular expressions? Currently it seems that specifying |
It's mostly related to the switch from
For sure. For now the check is happening in: jupyterlab/packages/debugger/src/panels/variables/tree.tsx Lines 119 to 121 in d895f35
So this logic could already be updated to test against regexes instead. |
When the user sets
variableFilters
in their own user settings, these should be merged with the defaults instead of overwriting them. If this behavior is something that users object to, we can add aboolean
to set whether the behavior is to merge or the overwrite in the future.The text was updated successfully, but these errors were encountered: