Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for data grid package #328

Open
Tracked by #233
afshin opened this issue Aug 4, 2022 · 4 comments
Open
Tracked by #233

Add tests for data grid package #328

afshin opened this issue Aug 4, 2022 · 4 comments
Labels
help wanted Please work on this if you are interested
Milestone

Comments

@afshin
Copy link
Member

afshin commented Aug 4, 2022

The DataGrid class is widely used and reliable. But it does not have any tests. Without tests, we risk regressions and unintended side-effects going forward.

@afshin afshin added the help wanted Please work on this if you are interested label Aug 4, 2022
@afshin afshin added this to the Lumino 2 milestone Aug 4, 2022
@afshin afshin mentioned this issue Aug 4, 2022
16 tasks
@gabalafou
Copy link
Contributor

I could take an attempt at this later this week. Of all the test files in the repo, which might be the most useful for me to study to help me get started on this one?

@afshin
Copy link
Member Author

afshin commented Aug 10, 2022

I think looking at the tests in the @lumino/widgets package is probably the best way to approach this.

@gabalafou gabalafou self-assigned this Aug 19, 2022
@gabalafou
Copy link
Contributor

I assigned myself this task but just you so know, I won't be able to start working on it until next week at the earliest.

@gabalafou
Copy link
Contributor

I think it would be interesting to explore this code some more, but I need to focus on https://github.com/Quansight-Labs/jupyter-a11y-testing, so I'm unassigning myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Please work on this if you are interested
Projects
No open projects
Status: not started
Development

No branches or pull requests

2 participants