Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove webpack from Lumino examples and code base #332

Closed
Tracked by #233
, #325
...
afshin opened this issue Aug 5, 2022 · 4 comments · Fixed by #348
Closed
Tracked by #233
, #325
...

Remove webpack from Lumino examples and code base #332

afshin opened this issue Aug 5, 2022 · 4 comments · Fixed by #348
Assignees
@gabalafou
Labels
dependencies Pull requests that update a dependency file help wanted Please work on this if you are interested maintenance Dependencies, build, technical debt, etc.
Milestone
Lumino 2

Comments

@afshin
Copy link
Member

afshin commented Aug 5, 2022

As commented in #330, it will be nice to drop webpack and to use rollup for the tests to remove any inconsistency between the packager used for publishing and for testing.
— @fcollonval #325 (comment)
@afshin afshin added help wanted Please work on this if you are interested dependencies Pull requests that update a dependency file maintenance Dependencies, build, technical debt, etc. labels Aug 5, 2022
@afshin afshin added this to the Lumino 2 milestone Aug 5, 2022
This was referenced Aug 5, 2022
Closed
Closed
@gabalafou
Copy link
Contributor

This looks interesting to me. I'll take a look today and provide a status update (via issue comments) tomorrow.

@gabalafou
Copy link
Contributor

I only had 30 minutes to look at this today. I will be able to take a longer look tomorrow and assess if and how long it will take me to do this.

@gabalafou gabalafou mentioned this issue Aug 13, 2022
Merged
@gabalafou
Copy link
Contributor

I opened a draft PR (#348) in which I converted the tests for @lumino/algorithm to use Rollup. I will next add a single example from the examples directory.

@gabalafou
Copy link
Contributor

Just a heads up that I won't be able to work on this some more until next week.

@gabalafou gabalafou mentioned this issue Sep 5, 2022
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gabalafou gabalafou

Labels
dependencies Pull requests that update a dependency file help wanted Please work on this if you are interested maintenance Dependencies, build, technical debt, etc.
Projects
No open projects
Lumino 2
Status: done
Milestone
Lumino 2
Development

Successfully merging a pull request may close this issue.

Use Rollup for tests and examples gabalafou/lumino
2 participants
@afshin @gabalafou