Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable a lumino dependancies to be built in serverside only code #470

Open
stevejpurves opened this issue Nov 23, 2022 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@stevejpurves
Copy link

stevejpurves commented Nov 23, 2022

Problem

It is not currently possible to statically include code that depends on @lumino/domutils in a platform that performs serverside code bundling. The objective here is not to enable SSR with lumino but to allow for packages that use lumino to be able to be easily used within the build environment of something like next.js or remix.

There is an equivalent issue open for jupyterlab here 13429

Proposed Solution

Remove or guard any references to browser only globals in lumino code where they occur at file scope or in objects or functions that are immediately executed on import.

@stevejpurves stevejpurves added the enhancement New feature or request label Nov 23, 2022
@welcome
Copy link

welcome bot commented Nov 23, 2022

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant