Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hoist the Python package to the top-level? #932

Closed
jtpio opened this issue Dec 23, 2022 · 2 comments
Closed

Hoist the Python package to the top-level? #932

jtpio opened this issue Dec 23, 2022 · 2 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@jtpio
Copy link
Member

jtpio commented Dec 23, 2022

Problem

Currently the jupyterlite Python package is located under py/jupyterlite: https://github.com/jupyterlite/jupyterlite/tree/main/py/jupyterlite

If I recall correctly this was mostly to accommodate the potential new Python packages that would be developed in the monorepo such as #165.

Proposed Solution

With the use of CLI addons and support for federated extensions, maybe there won't be any needs for new Python packages in the same jupyterlite repository.

If we want to provide more Python packages, maybe they could live outside of the main repo but within the jupyterlite org on GitHub: https://github.com/jupyterlite

Benefits for hoisting the Python package to the top-level would be:

Additional context

In #854 and some other issues there were also mentions of having a jupyterlite_core or jupyterliter, and make jupyterlite a metapackage to distribute JupyterLite with a set of pre-defined packages.

Even if that was the case, maybe the jupyterlite metapackage could then also live outside in the main repo but still in https://github.com/jupyterlite.

@jtpio jtpio added enhancement New feature or request question Further information is requested labels Dec 23, 2022
@bollwyvl
Copy link
Collaborator

The labextension should be a wholly separate thing, for sure, but i do semi-lament use of [extras] for really anything, which means we'll have rather a lot of packages... and having them cut from the same tag of the repo really does feel better than setting up parallel structure (even if simple) on a bunch of repos, and having to coordinate releases.

same structure as many other Jupyter projects

Again, as with #881, as long whatever the buildchain is, it:

  • generates reproducible tarballs
  • can support building multiple packages
  • is entirely installable from conda-forge packages
  • doesn't break every time pip or packaging or whatever changes
  • doesn't use the python packaging tool as the main CLI entrypoint, exposing only "do everything"
  • doesn't create mountains of private, un-managed envs in magic places
  • doesn't do any fancy nodejs stuff

So basically:

  • treat whatever the python packaging tool is as just a node on the graph of things that need building
  • don't get rid of doit

@jtpio
Copy link
Member Author

jtpio commented Mar 7, 2023

Closing as we'll want to keep several Python packages in the same repo: #993

@jtpio jtpio closed this as completed Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants